Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spdk/autorun_post on common tests artifacts #24

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

karlatec
Copy link
Contributor

Generate code coverage and run tests summary.
Script is run with "-s" flag which makes autorun_post NOT fail in case not all tests were run.

@karlatec karlatec force-pushed the karlatec/tests-post-process branch 2 times, most recently from 2789c64 to cb289a0 Compare February 24, 2025 08:22
Using Github download/upload artifact actions results
in "autorun_*_artifacts" directory created when
extracting from "autorun_*_artifacts.zip".

Removing one level from path (e.g. "/opt/output/nvme")
saves later trouble with handling nested directories.

Signed-off-by: Karol Latecki <[email protected]>
@karlatec karlatec force-pushed the karlatec/tests-post-process branch 4 times, most recently from d0987ae to 5c7b695 Compare February 24, 2025 12:37
Generate code coverage and run tests summary.
Script is run with "-s" flag which makes autorun_post
NOT fail in case not all tests were run.

Signed-off-by: Karol Latecki <[email protected]>
@karlatec karlatec force-pushed the karlatec/tests-post-process branch from 5c7b695 to f6d2e9c Compare February 24, 2025 13:24
Copy link
Contributor

@tomzawadzki tomzawadzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

run: |
tar xf ${{ env.spdk_path }}/repository.tar.gz -C ${{ env.spdk_path }}

# TODO: either use an official lcov image or create our own
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to me for now, but in the end we should use the container image used for testing (#26).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in the end we should use the container image used for testing

Definietly!

@tomzawadzki tomzawadzki merged commit bc0bd33 into spdk:main Feb 28, 2025
7 checks passed
@karlatec karlatec deleted the karlatec/tests-post-process branch March 4, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants